This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
MultiInfo is no longer preserved through serialization + parsing #2253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like since #2212, when we serialize a
MultiInfo
it can be turned into a singleFileInfo
node. This is a problem for applications that need to parse the emitted source locator, like my formal verification library: https://github.com/ekiwi/kiwi-formal/blob/main/test/kiwi/formal/backends/ErrorParserTest.scala#L39Contributor Checklist
Type of Improvement
API Impact
Backend Code Generation Impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
Please Merge
?