Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

MultiInfo is no longer preserved through serialization + parsing #2253

Closed
wants to merge 1 commit into from

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Jun 2, 2021

It looks like since #2212, when we serialize a MultiInfo it can be turned into a single FileInfo node. This is a problem for applications that need to parse the emitted source locator, like my formal verification library: https://github.com/ekiwi/kiwi-formal/blob/main/test/kiwi/formal/backends/ErrorParserTest.scala#L39

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi
Copy link
Contributor Author

ekiwi commented Jun 17, 2021

This is going to be fixed in: #2265

@ekiwi ekiwi closed this Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant