Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Add Protocol Buffer emission #2271

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Add Protocol Buffer emission #2271

merged 2 commits into from
Jun 17, 2021

Conversation

seldridge
Copy link
Member

This adds infrastructure and annotations that let a user emit a FIRRTL
circuit as a Protocol Buffer.

Fixes #1696.

Signed-off-by: Schuyler Eldridge [email protected]

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • [n/a] Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Pure API extension. Adds protocol buffer emission.

Backend Code Generation Impact

None.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

  • Add ProtoBuf emission, e.g., -X high-pb

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@seldridge
Add Protocol Buffer emission export
049cd8f 
This adds infrastructure and annotations that let a user emit a FIRRTL
circuit as a Protocol Buffer.

Fixes #1696.

Signed-off-by: Schuyler Eldridge <[email protected]>
@seldridge seldridge changed the title Add Protocol Buffer emission export Add Protocol Buffer emission Jun 16, 2021
jackkoenig
jackkoenig suggested changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have, just a couple of issues.

src/main/scala/firrtl/Emitter.scala Outdated Show resolved Hide resolved
src/test/scala/firrtlTests/stage/FirrtlMainSpec.scala Outdated Show resolved Hide resolved
src/main/scala/firrtl/backends/proto/ProtoBufEmitter.scala Outdated Show resolved Hide resolved
@seldridge seldridge force-pushed the dev/seldridge/protobuf-emission branch from f1c1812 to 39d0887 Compare June 17, 2021 00:25
@jackkoenig jackkoenig added this to the 1.4.x milestone Jun 17, 2021
jackkoenig
jackkoenig approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jun 17, 2021
@mergify mergify bot merged commit d708d3f into master Jun 17, 2021
mergify bot pushed a commit that referenced this pull request Jun 17, 2021
@seldridge
Add Protocol Buffer emission (#2271)
a4e9b68 
* Add Protocol Buffer emission export

This adds infrastructure and annotations that let a user emit a FIRRTL
circuit as a Protocol Buffer.

Fixes #1696.

Signed-off-by: Schuyler Eldridge <[email protected]>

* fixup! Add Protocol Buffer emission export

(cherry picked from commit d708d3f)
@mergify mergify bot mentioned this pull request Jun 17, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Jun 17, 2021
@seldridge seldridge deleted the dev/seldridge/protobuf-emission branch June 17, 2021 03:54
seldridge added a commit that referenced this pull request Jun 17, 2021
@seldridge
Add Protocol Buffer emission (#2271)
5faa57c 
* Add Protocol Buffer emission export

This adds infrastructure and annotations that let a user emit a FIRRTL
circuit as a Protocol Buffer.

Fixes #1696.

(cherry picked from commit d708d3f)
seldridge added a commit that referenced this pull request Jun 17, 2021
@seldridge
Add Protocol Buffer emission (#2271)
56f1de8 
* Add Protocol Buffer emission export

This adds infrastructure and annotations that let a user emit a FIRRTL
circuit as a Protocol Buffer.

Fixes #1696.

(cherry picked from commit d708d3f)
mergify bot added a commit that referenced this pull request Jun 17, 2021
@mergify @seldridge
Add Protocol Buffer emission (#2271) (#2272)
4d6cf34 
* Add Protocol Buffer emission export

This adds infrastructure and annotations that let a user emit a FIRRTL
circuit as a Protocol Buffer.

Fixes #1696.

(cherry picked from commit d708d3f)

Co-authored-by: Schuyler Eldridge <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.4.x
Development

Successfully merging this pull request may close these issues.

Add Protobuf FIRRTL Emitters
2 participants
@seldridge @jackkoenig