Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

[smt] treat stop with non-zero ret like an assertion #2338

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Aug 26, 2021

We treat it as an assertion that the stop will never be enabled. stop(0) will still be ignored (but now demoted to a info from a warning).

Contributor Checklist

  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?

Type of Improvement

  • smt backend code generation

API Impact

  • demotes some warnings to info
  • stop with non-zero return code are now emitted similar to assertions instead of being ignored

Backend Code Generation Impact

  • only impacts smt/btor generation, no impact on Verilog

Desired Merge Strategy

  • squash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi ekiwi requested a review from jackkoenig August 26, 2021 03:32
@ekiwi ekiwi added this to the 1.5.0 milestone Aug 26, 2021
We treat it as an assertion that the stop will
never be enabled. stop(0) will still be ignored
(but now demoted to a info from a warning).
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense!

@ekiwi ekiwi merged commit de56a19 into chipsalliance:master Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants