Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Multi PB backport fixes #2353

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Multi PB backport fixes #2353

merged 2 commits into from
Sep 8, 2021

Conversation

jared-barocsi
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig merged commit 1036cb6 into chipsalliance:mergify/bp/1.4.x/pr-2344 Sep 8, 2021
mergify bot added a commit that referenced this pull request Sep 8, 2021
@mergify @jared-barocsi
Multi protobuf module emission and consumption (backport #2344) (#2352)
2bfecd9 
* Multi protobuf module emission and consumption (#2344)

* Add compiler option (`-p`) to emit individual module protobufs
* Implement multi module combination when reading directory of protobufs

Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 0c1ca58)

* Multi PB backport fixes (#2353)

Co-authored-by: Jared Barocsi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jared-barocsi @jackkoenig @jardhu