Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Support parsing missing keywords as ids #2381

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Oct 8, 2021

Reset, AsyncReset, Interval, attach, assert, assume, and cover have all
been added as keywords but not added to the allowlist for parsing as
ids.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

Accept more keywords as ids in parsing

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Support parsing more keywords as identifiers: Reset, AsyncReset, Interval, attach, assert, assume, and cover

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 1.3.x milestone Oct 8, 2021
Reset, AsyncReset, Interval, attach, assert, assume, and cover have all
been added as keywords but not added to the allowlist for parsing as
ids.
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Oct 9, 2021
@mergify mergify bot merged commit ef1d27a into master Oct 9, 2021
mergify bot pushed a commit that referenced this pull request Oct 9, 2021
Reset, AsyncReset, Interval, attach, assert, assume, and cover have all
been added as keywords but not added to the allowlist for parsing as
ids.

(cherry picked from commit ef1d27a)

# Conflicts:
#	src/test/scala/firrtlTests/ParserSpec.scala
mergify bot pushed a commit that referenced this pull request Oct 9, 2021
Reset, AsyncReset, Interval, attach, assert, assume, and cover have all
been added as keywords but not added to the allowlist for parsing as
ids.

(cherry picked from commit ef1d27a)
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Oct 9, 2021
@jackkoenig jackkoenig deleted the parse-more-keywords branch October 9, 2021 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants