Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Remove The WriteEmitted Phase #2390

Merged
merged 4 commits into from
Oct 19, 2021
Merged

Remove The WriteEmitted Phase #2390

merged 4 commits into from
Oct 19, 2021

Conversation

davidbiancolin
Copy link
Contributor

@davidbiancolin davidbiancolin commented Oct 15, 2021

WriteEmitted is scheduled for removal in 1.5. This removes it.

I'm not sure switching the phase FirrtlEquivalenceTest is a direct port, that could use some eyes.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code cleanup

API Impact

Removes code on the 1.5 deprecation schedule.

Backend Code Generation Impact

None

Desired Merge Strategy

  • Squash

Release Notes

Remove The WriteEmitted Phase

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yay deleting code

@davidbiancolin davidbiancolin enabled auto-merge (squash) October 19, 2021 20:45
@davidbiancolin davidbiancolin merged commit 5532d50 into master Oct 19, 2021
@davidbiancolin davidbiancolin deleted the remove-write-emitted branch October 19, 2021 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants