Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Update spec on extmodule with defname, parameter #2413

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Update spec on extmodule with defname, parameter #2413

merged 2 commits into from
Nov 12, 2021

Conversation

seldridge
Copy link
Member

Contributor Checklist

  • [n/a] Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • [n/a] Did you add at least one test demonstrating the PR?
  • [n/a] Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation

API Impact

None.

Backend Code Generation Impact

None.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@seldridge seldridge changed the title Dev/seldridge/spec extmodule defname parameter Update spec on extmodule with defname, parameter Nov 10, 2021
@seldridge
Add defname, parameter to extmodule spec, NFC
7278d31 
Signed-off-by: Schuyler Eldridge <[email protected]>
@seldridge
Update spec.pdf, NFC
630d26a 
Signed-off-by: Schuyler Eldridge <[email protected]>
@seldridge seldridge force-pushed the dev/seldridge/spec-extmodule-defname-parameter branch from 9e6110d to 630d26a Compare November 12, 2021 18:30
jackkoenig
jackkoenig approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

We also really need to increment the version of this document. Maybe market it as "incomplete" Like FIRRTL v2.0-prerelease or something

@jackkoenig jackkoenig merged commit 03af969 into master Nov 12, 2021
@jackkoenig jackkoenig deleted the dev/seldridge/spec-extmodule-defname-parameter branch November 12, 2021 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seldridge @jackkoenig