This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Deprecate all mutable methods on RenameMap and add MutableRenameMap #2444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecation
undeprecated a while ago
Much friendlier version of #2318
Contributor Checklist
Type of Improvement
API Impact
This deprecates all mutable methods on
RenameMap
, the exact same functionality is maintained on the newfirrtl.renamemap.MutableRenameMap
.RenameMap
is also now a [sealed] trait which will enable alternative (optimized) implementations in the future.Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Deprecate all mutable methods on
RenameMap
. For constructingRenameMaps
, usefirrtl.renamemap.MutableRenameMap
.Reviewer Checklist (only modified by reviewer)
Please Merge
?