This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
preset: make PropagatePreset play nice with verification statements #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekiwi
force-pushed
the
register-preset-removal
branch
from
e7e23e7
to
190cebd
Compare
ekiwi
force-pushed
the
register-preset-removal
branch
from
190cebd
to
3908260
Compare
ekiwi
added
the
Please Merge
Verification statements are guarded by reset. If this reset happens to be a "preset" type reset, they should always be active. The easiest way to achieve that is to replace all uses of "preset" resets with zero.
ekiwi
force-pushed
the
register-preset-removal
branch
from
3908260
to
77ee557
Compare
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Jan 19, 2022
…2453) (#2467) Verification statements are guarded by reset. If this reset happens to be a "preset" type reset, they should always be active. The easiest way to achieve that is to replace all uses of "preset" resets with zero. (cherry picked from commit c98ee33) Co-authored-by: Kevin Laeufer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification statements are guarded by reset.
If this reset happens to be a "preset" type
reset, they should always be active.
The easiest way to achieve that is to replace
all uses of "preset" resets with zero.
Fixes #2348
Contributor Checklist
Type of Improvement
API Impact
Backend Code Generation Impact
Desired Merge Strategy
Reviewer Checklist (only modified by reviewer)
Please Merge?