Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

[smt] correct comparison for out-of-bounds memory access check #2463

Merged
merged 1 commit into from
Jan 17, 2022
Merged

[smt] correct comparison for out-of-bounds memory access check #2463

merged 1 commit into from
Jan 17, 2022

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Jan 17, 2022

This fixes an off by one error, where 3 was erroneously
accepted as in-bounds for a memory of depth=3

Contributor Checklist

  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?

Type of Improvement

  • bug fix

API Impact

  • none

Backend Code Generation Impact

  • no impact on verilog, just fixes a bug connected to the formal backend

Desired Merge Strategy

  • squash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi ekiwi requested a review from jackkoenig January 17, 2022 22:38
@jackkoenig
Copy link
Contributor

Seems reasonable to me but there is a test failure.

@ekiwi
[smt] correct comparison for out-of-bounds memory access check
2ec23fd 
This fixes an off by one error, where 3 was erroneously
accepted as in-bounds for a memory of depth=3
@ekiwi ekiwi force-pushed the undefined-mem-behavior-oob-fix branch from 3dbaea0 to 2ec23fd Compare January 17, 2022 23:15
@ekiwi ekiwi added this to the 1.5.x milestone Jan 17, 2022
@jackkoenig jackkoenig enabled auto-merge (squash) January 17, 2022 23:25
@jackkoenig jackkoenig merged commit 5569c72 into chipsalliance:master Jan 17, 2022
mergify bot pushed a commit that referenced this pull request Jan 17, 2022
@ekiwi
[smt] correct comparison for out-of-bounds memory access check (#2463)
d4a0b5e 
This fixes an off by one error, where 3 was erroneously
accepted as in-bounds for a memory of depth=3

(cherry picked from commit 5569c72)
@mergify mergify bot mentioned this pull request Jan 17, 2022
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Jan 17, 2022
mergify bot added a commit that referenced this pull request Jan 17, 2022
@mergify @ekiwi
[smt] correct comparison for out-of-bounds memory access check (#2463) (
ddd4989 
#2464)

This fixes an off by one error, where 3 was erroneously
accepted as in-bounds for a memory of depth=3

(cherry picked from commit 5569c72)

Co-authored-by: Kevin Laeufer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch
Projects
None yet
Milestone
1.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ekiwi @jackkoenig