Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

emission-options flags swapped #2472

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

Andful
Copy link
Contributor

@Andful Andful commented Jan 25, 2022

emission-options flags swapped to match their functionality

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Fixed emission-options flags to match their functionality.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

This fails CI due to automatic formatting, would you mind running
sbt scalafmtAll to fix the issue?

I'd like to set up a Github Actions bot to push commits fixing formatting automatically, but I just haven't gotten around to it yet.

emission-options flags swapped to match their functionality
@Andful
Copy link
Contributor Author

Andful commented Jan 25, 2022

Yes, now the file should be formatted

@jackkoenig jackkoenig added this to the 1.5.x milestone Jan 25, 2022
@jackkoenig jackkoenig merged commit 922f58c into chipsalliance:master Jan 25, 2022
mergify bot pushed a commit that referenced this pull request Jan 25, 2022
emission-options flags swapped to match their functionality

(cherry picked from commit 922f58c)
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Jan 25, 2022
mergify bot added a commit that referenced this pull request Jan 25, 2022
emission-options flags swapped to match their functionality

(cherry picked from commit 922f58c)

Co-authored-by: Andrea Nardi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backported This PR has been backported to marked stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants