This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Use circuit name hashCode for circuit anno hashCode #2504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear if having more than one circuit annotation even works. If
it does, it is implausible that they would have the same circuit name
since that would correspond to a namespace collision.
Looking at flamegraphs, FirrtlCircuitAnnotation.hashCode always comes up. Creating a HashMap with different Circuits that nevertheless have the same name is extremely uncommon so collisions are not a concern. Include productPrefix so that this doesn't collide with other types that use a similar strategy and hash the same String.
This speeds up anything using Stage/Phase with FIRRTL Circuits which includes Chisel
Contributor Checklist
Type of Improvement
API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Improve performance of
FirrtlCircuitAnnotation.hashCode
. This speeds up all uses of Stage/Phase.Reviewer Checklist (only modified by reviewer)
Please Merge
?