Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for julia-nightly #114

Merged
merged 3 commits into from
Apr 28, 2024
Merged

Add CI for julia-nightly #114

merged 3 commits into from
Apr 28, 2024

Conversation

odow
Copy link
Collaborator

@odow odow commented Apr 26, 2024

x-ref #113

@odow
Copy link
Collaborator Author

odow commented Apr 26, 2024

cc @lassepe do you have a reproducible example of the failure? I'm reticent to make any changes without one.

@odow
Copy link
Collaborator Author

odow commented Apr 27, 2024

@lassepe can you try this PR?

@lassepe
Copy link
Contributor

lassepe commented Apr 28, 2024

I do not have a compact reproducer for this issue. The setting in which this came up is that I noticed that the toy example from the readme of https://github.com/forrestlaine/QuadraticProgramNetworks.jl fails on 1.11-beta1:

julia> qpn = setup(:robust_avoid_simple);
julia> ret = solve(qpn);

Hence, I started looking into what may cause these problems. @vchuravy pointed out on slack that the use of pointer_to_objref here is illegal and that recent changes to the GC may have caused this to fail now.

Unfortunately, the changes in your PR (and those made in my original PR) did not fix the problems observed in https://github.com/forrestlaine/QuadraticProgramNetworks.jl. I will keep digging to see what is the problem there. Nonetheless, I think this PR is a step in the right direction since the current use of pointer_to_objref may cause hard-to-debug problems at any point in the future. In fact, I have already observed segfaults in the past when using the presolve interface which may very well have been caused by the illegal use of pointer_to_objref.

@odow
Copy link
Collaborator Author

odow commented Apr 28, 2024

Can you open an issue with the full error logs? What happens?

Unfortunately, the changes in your PR (and those made in my original PR) did not fix the problems

So this PR is, in fact, unrelated?

@odow
Copy link
Collaborator Author

odow commented Apr 28, 2024

I get

julia> using QuadraticProgramNetworks

julia> qpn = setup(:robust_avoid_simple);

julia> ret = solve(qpn);
Infiltrating project(p::QuadraticProgramNetworks.BasicPoly, keep_dims::Vector{Int64}; tol::Float64)
  at /Users/oscar/.julia/packages/QuadraticProgramNetworks/Iq7xw/src/sets.jl:520ime: 0:00:03
Depth 2: 100%|███████████████████████████████████████████████████████████████| Time: 0:00:03

WARNING: both CairoMakie and Base export "Text"; uses of it in module QuadraticProgramNetworks must be qualified
WARNING: both CairoMakie and LinearAlgebra export "rotate!"; uses of it in module QuadraticProgramNetworks must be qualified
WARNING: both CairoMakie and Polyhedra export "lines"; uses of it in module QuadraticProgramNetworks must be qualified
WARNING: both CaioMakie and Polyhedra export "surface"; uses of it in module QuadraticProgramNetworks must be qualified
WARNING: both CairoMakie and Polyhedra export "volume"; uses of it in module QuadraticProgramNetworks must be qualified
WARNING: both FilePathsBase and Base export "isexecutable"; uses of it in module FilePaths must be qualified
WARNING: both CairoMakie and Polyhedra export "lift"; uses of it in module QuadraticProgramNetworks must be qualified
infil> 

Can you open an issue with a reproducible example and explain what PATHSolver has to do with it?

@odow odow merged commit 2486535 into master Apr 28, 2024
9 checks passed
@odow odow deleted the od/fix-nightly branch April 28, 2024 22:00
@lassepe
Copy link
Contributor

lassepe commented Apr 29, 2024

First, thank you for merging this PR! :)

So this PR is, in fact, unrelated?

Yes, mostly unrelated. The issue fixed in this PR may be part of the solution but there must be more issues that we haven't found yet.

I get [...]. Can you open an issue with a reproducible example and explain what PATHSolver has to do with it?

I will open an issue with a clearer description once I have a smaller reproducer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants