feat(nested-domains) Disable delete if domain has subdomains (datahub…

…-project#1700)
chriscollins3456 · Aug 30, 2023 · 5b4e16d · 5b4e16d
2 parents 9f38b2a + ed842a1
commit 5b4e16d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/datahub-web-react/src/app/entity/shared/EntityDropdown/EntityDropdown.tsx b/datahub-web-react/src/app/entity/shared/EntityDropdown/EntityDropdown.tsx
@@ -131,6 +131,7 @@ function EntityDropdown(props: Props) {
 
     const pageUrl = window.location.href;
     const isGlossaryEntity = entityType === EntityType.GlossaryNode || entityType === EntityType.GlossaryTerm;
+    const isDomainEntity = entityType === EntityType.Domain;
     const entityHasChildren = !!entityData?.children?.total;
     const canManageGlossaryEntity = !!entityData?.privileges?.canManageEntity;
     const canCreateGlossaryEntity = !!entityData?.privileges?.canManageChildren;
@@ -210,11 +211,12 @@ function EntityDropdown(props: Props) {
                                 onClick={onDeleteEntity}
                             >
                                 <Tooltip
-                                    title={`Can't delete ${entityRegistry.getEntityName(
-                                        entityType,
-                                    )} with child entities.`}
+                                    title={`Can't delete ${entityRegistry.getEntityName(entityType)} with ${
+                                        isDomainEntity ? 'sub-domain' : 'child'
+                                    } entities.`}
                                     overlayStyle={
-                                        isGlossaryEntity && canManageGlossaryEntity && entityHasChildren
+                                        (isGlossaryEntity && canManageGlossaryEntity && entityHasChildren) ||
+                                        (isDomainEntity && entityHasChildren)
                                             ? {}
                                             : { display: 'none' }
                                     }

diff --git a/datahub-web-react/src/app/entity/shared/EntityDropdown/utils.ts b/datahub-web-react/src/app/entity/shared/EntityDropdown/utils.ts
@@ -11,5 +11,10 @@ export function isDeleteDisabled(entityType: EntityType, entityData: GenericEnti
     if (entityType === EntityType.DataProduct) {
         return false; // TODO: update with permissions
     }
+    if (entityType === EntityType.Domain) {
+        const entityHasChildren = !!entityData?.children?.total;
+        const canDeleteDomainEntity = !entityHasChildren;
+        return !canDeleteDomainEntity;
+    }
     return false;
 }
diff --git a/datahub-web-react/src/graphql/domain.graphql b/datahub-web-react/src/graphql/domain.graphql
@@ -37,6 +37,9 @@ query getDomain($urn: String!) {
                 }
             }
         }
+        children: relationships(input: { types: ["IsPartOf"], direction: INCOMING, start: 0, count: 0 }) {
+            total
+        }
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,6 +37,9 @@ query getDomain($urn: String!) { @@
                     }
                 }
             }
+            children: relationships(input: { types: ["IsPartOf"], direction: INCOMING, start: 0, count: 0 }) {
+                total
+            }
         }
     }
@@ Expand Down @@