[CLN] remove dead code in metadata proto conversion

chroma-core · Apr 30, 2024 · d82fbc8 · d82fbc8
1 parent 0a3af05
commit d82fbc8
Showing 1 changed file with 3 additions and 17 deletions.
diff --git a/chromadb/segment/impl/metadata/grpc_segment.py b/chromadb/segment/impl/metadata/grpc_segment.py
@@ -247,23 +247,9 @@ def _where_to_proto(self, where: Optional[Where]) -> pb.Where:
                                 f"Expected where operand value to be a string, int, or float, got {operand}"
                             )
                     else:
-                        # Our key is a metadata field name and the value is meant
-                        # to be compared for strict equality.
-                        if type(operand) is str:
-                            ssc = pb.SingleStringComparison()
-                            ssc.value = operand
-                            ssc.comparator = pb.GenericComparator.EQ
-                            dc.single_string_operand.CopyFrom(ssc)
-                        elif type(operand) is int:
-                            sic = pb.SingleIntComparison()
-                            sic.value = operand
-                            sic.generic_comparator = pb.GenericComparator.EQ
-                            dc.single_int_operand.CopyFrom(sic)
-                        elif type(operand) is float:
-                            sfc = pb.SingleDoubleComparison()
-                            sfc.value = operand
-                            sfc.generic_comparator = pb.GenericComparator.EQ
-                            dc.single_double_operand.CopyFrom(sfc)
+                        # This case should never happen, as we've already
+                        # handled the case for direct comparisons.
+                        pass
 
             response.direct_comparison.CopyFrom(dc)
         return response