Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Refactor memberlist reconciliation in MemberlistManager #2071

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Ishiihara
Copy link
Contributor

@Ishiihara Ishiihara commented Apr 27, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This PR fixes the issue that the memberlist manager is not propagating the memberlist to downstream. The issue is that the Get function for the worker queue is blocking when the queue is empty. The end result is that if the number of events is not cumulated to the batch size, the memberlist may block waiting and not propagate the memberlist with timeout.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Ishiihara and the rest of your teammates on Graphite Graphite

@Ishiihara Ishiihara changed the title Fix memberlist hang [BUG] Fix memberlist hang Apr 27, 2024
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Ishiihara Ishiihara changed the title [BUG] Fix memberlist hang [ENH] Refactor memberlist reconciliation in MemberlistManager Apr 27, 2024
@Ishiihara Ishiihara changed the title [ENH] Refactor memberlist reconciliation in MemberlistManager [BUG] Refactor memberlist reconciliation in MemberlistManager Apr 27, 2024
@Ishiihara Ishiihara force-pushed the liquan_memberlist_bug_fix branch from 7cc1bdc to 25f53e9 Compare April 27, 2024 04:01
@Ishiihara Ishiihara marked this pull request as ready for review April 29, 2024 16:26
@Ishiihara Ishiihara requested review from HammadB and beggers April 29, 2024 16:26
@Ishiihara Ishiihara self-assigned this Apr 29, 2024
@Ishiihara Ishiihara merged commit bb7863a into main Apr 29, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants