Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN] Favor kubernetes port forwards in tilt over test loadbalancers #2082

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Apr 30, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This favors kubernetes port forwards in the tiltfile over kubernetes services. These serve the same goal. Centralizing in tilt is cleaner because tilt is the definition of the dev stack and its better to minimize the test k8s yaml.
  • New functionality
    • None

Test plan

How are these changes tested?
Integration tests in CI

  • [] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link
Collaborator Author

HammadB commented Apr 30, 2024

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB requested review from beggers and Ishiihara April 30, 2024 06:22
@beggers beggers merged commit 11d1c87 into hammad/lint_fix Apr 30, 2024
123 checks passed
@HammadB HammadB mentioned this pull request Apr 30, 2024
HammadB added a commit that referenced this pull request Apr 30, 2024
This is a dupe of #2082 targeted at main because it was accidentally
merged into the stacked PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants