This repository has been archived by the owner on Jan 15, 2023. It is now read-only.
Upgrade to CefSharp 89.0.170 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove x86/x64 platforms from the solution - Chromely.CefSharp.Integration.TestApp sets RuntimeIdentifier - Change TargetFrameworks to net462;netcoreapp3.1;net5.0-windows **KNOWN ISSUES** - The generated Nuget package has exclude buildTransitive set which will likely break the package (not tested, though very likely) The CefSharp.Common.NETCore.targets included in the buildTransitive has a hack to support AnyCPU which adds package references directly to the chromiumembeddedframework.runtime.win-x64 and chromiumembeddedframework.runtime.win-x86 packages Will need to add some configuration options to CefSharp to disable this behaviour, I've added a task to cefsharp/CefSharp#3388
Thanks for the info. Will see about merging this by the weekend. |
To resolve the transitive dependency issues a few changes are required to the CefSharp Nuget packages. I'll post an update when they're done and tested. |
|
Standing by ... |
amaitland
changed the title
|
I've upgraded to |
amaitland
changed the title
|
I've upgraded to Should hopefully be good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had to remove the
netstandard2.0;netstandard2.1targetframeworks, it's not possible to target.Net Standard.C++/CLIdoesn't support targeting.Net Standard, soCefSharpcannot produce anetstandardlib. For reference https://docs.microsoft.com/en-us/dotnet/core/porting/cpp-cliIt wasn't really ever supported. The
CefSharpnuget packages are now more standardises and include most of the managed libs in thelib\net452folder, so thenetstandardtarget won't resolve to those (at least in my experience).Switched to using a dependency group option where the appropriate nuget package is included based on the targetFramework.
87.KNOWN ISSUES
The generated Nuget package has exclude buildTransitive set which will likely break the package (not tested, though very likely)The CefSharp.Common.NETCore.targets included in the buildTransitive folder has a hack to support AnyCPU which adds package references
directly to the chromiumembeddedframework.runtime.win-x64 and chromiumembeddedframework.runtime.win-x86 packages
Will need to add some configuration options to CefSharp to disable this behaviour, I've added a task to Net Core/Net 5 - Enhancements cefsharp/CefSharp#3388
Because of the known issue listed above a workaround would be required, two untested options are:
CefSharp.CommonorCefSharp.Common.NETCoreas a direct PackageReferenceIncludeAssetson thePackageReferenceNeed to clone https://github.com/chromelyapps/demo-projects and test out the resulting nuget package.