New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwraps and other runtime panics that result from invalid input #56

Open

Gnurou opened this issue Nov 25, 2023 · 1 comment

Collaborator

Gnurou commented Nov 25, 2023 •

edited

Loading

An invalid stream should not make the program panic. This issue is to track the removal of all sources of panic from the code:

unwraps as a result of invalid input,
Explicit calls to panic and expect,
Potentially out-of-bounds accesses in vectors or array (replace them with get).

The text was updated successfully, but these errors were encountered:

Gnurou added a commit that referenced this issue


          decoder/vp9: replace unwrap by runtime error

0b0d71b

As per #56.

Gnurou added a commit that referenced this issue


          codec/h264/dpb: replace unwrap by proper error

679c632

As per #56.

Collaborator

dwlsalmeida commented Dec 5, 2023

I assume we can still panic from logic errors and general sanity-checks from asserts and friends, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment