Add From<NaiveDate> for NaiveDateTime #1355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
From<NaiveDate>
toNaiveDateTime
to facilitate more flexible APIs.Motivation
Some users of the
chrono
library may want to create functions that can take bothNaiveDate
andNaiveDateTime
. Without this trait that is not necessarily possible. CurrentlyNaiveDate
implementsFrom<NaiveDateTime>
so they could build an API that takesNaiveDateTime
s and converts themNaiveDate
s but the reverse is not possible.Currently only this is possible:
The function above can handle
NaiveDate
orNaiveDateTime
input where the body can use the input to get aNaiveDate
.With my changes, this will be possible as well:
Here the use has created a function that can take
NaiveDate
orNaiveDateTime
and get aNaiveDateTime
. While ostensibly a small change, it gives chrono users the ability to create more powerful and flexible APIs.Thank you for considering my pull request.