CI: Reduce combinations in cargo hack check
#1553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why but within the last week the combinations
cargo hack check
tries on our CI has increased 4x to 672. Cargo hack has seen a couple of new releases, so there may be a change or bugfix there.Disabling the
oldtime
(unused) andwasmbind
(not checked on linux anyway) features reduces it back to 192 combinations.We can also now inform cargo hack that some features are mutually exclusive, or don't effect each other. The
rkyv
features are truly mutually exclusive. Thearbitrary
feature is far removed from serialization, and serde also doesn't seem to have anything in common with rkyv. So I think we can treat them as mutually exclusive.This allows us to run
cargo hack check
for more meaningful combinations with therkyv-*
features while we only check 84 combinations. Room to grow again 😄.This should bring our CI time back below 5 minutes instead of close to 20 minutes.