164 extend visualization support for lotka volterra and ensembles #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes index-based replacements (a source of brittleness in the substitutions being done.)
…olterra-and-ensembles
JosephCottam
added
the
WIP
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This is useful when the sample points are relatively dense.
NOTE: Its possible the `convert_to_output_format` has a bug. It is returning step-ids, not time-values. As-such, intervention markers were set to 250 instead of 25.
Extended integration interface to preserve timepoint (not just timepoint_id) Renamed 'vega' to 'plots' Updated examples (Some) Utility tests Cleanup of various files
…olterra-and-ensembles
…4-extend-visualization-support-for-lotka-volterra-and-ensembles
…4-extend-visualization-support-for-lotka-volterra-and-ensembles
…4-extend-visualization-support-for-lotka-volterra-and-ensembles
…4-extend-visualization-support-for-lotka-volterra-and-ensembles
|
Is this ready for review? If so, can we change the tag? Probably a low priority until after the hackathon. |
|
No, it is not ready for review. The regnet versions do not work yet, so
the overall PR is not ready for merge. However, much of it came in when
the trajectory visualizations did.
…--JC
On Fri, Jul 14, 2023 at 12:18 AM Sam Witty ***@***.***> wrote:
Is this ready for review? If so, can we change the tag?
Probably a low priority until after the hackathon.
—
Reply to this email directly, view it on GitHub
<#208 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWTUFMVV6TCCNWAWFFKGY3XQDCATANCNFSM6AAAAAA2A4S2AM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@JosephCottam , has this PR been subsumed by #469 ? |
|
Subsumed by #469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.