fix(fork-test.c) Call MANAGERPID from env var when systemd run with --user flag
#3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptSathi
force-pushed
the
pr/ScriptSathi/fix-fork_test-return-nil-on-error
branch
2 times, most recently
from
8e71878
to
d245eec
Compare
|
@kkourt, here is the fix working for me on Archlinux. I manage to get the output of Thank you for your help on this 💯 |
ScriptSathi
force-pushed
the
pr/ScriptSathi/fix-fork_test-return-nil-on-error
branch
from
d245eec
to
109719d
Compare
ScriptSathi
changed the title
--user flag
ScriptSathi
changed the title
--user flag--user flag
kkourt
requested changes
Nov 21, 2024
mtardy
added
the
release-note/misc
ScriptSathi
force-pushed
the
pr/ScriptSathi/fix-fork_test-return-nil-on-error
branch
from
109719d
to
ad77730
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ScriptSathi
force-pushed
the
pr/ScriptSathi/fix-fork_test-return-nil-on-error
branch
from
ad77730
to
6c0b4b3
Compare
kkourt
reviewed
Nov 22, 2024
ScriptSathi
force-pushed
the
pr/ScriptSathi/fix-fork_test-return-nil-on-error
branch
2 times, most recently
from
f154425
to
987c58e
Compare
…ppid The initial goal of fork-tester.c is to test that subchild (child2) find systemd pid has new parent with hardcoded pid 1. But we can produce the same behaviour by controlling the new parent of a subchild process when his parent dies by using `PR_SET_CHILD_SUBREAPER`. The main process register as reaper, which means that any childrens and childrens of childrens will have this main process as parent when their closest parent dies. So here with have main process as reaper, child1 creates a subchild (child2) then dies. But child2 is no more orphan with systemd as parent, main process catch it. This add more control over the process tree and should work for any cases. Signed-off-by: Tristan d'Audibert <[email protected]>
This update comes after updating the `fork-tester.c`. The parent inherent grand children child 2 when child 1 dies. In order to ensure that this specific behaviour occurs, we need to compare parent PID with new parent PID of child 2 which is suppose to be parent PID instead of child PID. Signed-off-by: Tristan d'Audibert <[email protected]>
ScriptSathi
force-pushed
the
pr/ScriptSathi/fix-fork_test-return-nil-on-error
branch
from
987c58e
to
96abbdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3148
Description
A nil pointer is returned by
ctx.Err()becausectxis not done when the error is displayed.More details
On some distributions, like Archlinux, systemd run with the flag
--user. Thus, makes the user manager process a child of systemd process 1. So when you search for PPID, it will always be this child process.According to the documentation below, systemd expose an environnement variable to help finding this children. So if we compare the value of this environment variable with the ppid, we should get the same result as doing
ppid == 1https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#%24MANAGERPID