Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version flag #108

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Add --version flag #108

merged 1 commit into from
Apr 20, 2022

Conversation

LegenJCdary
Copy link
Collaborator

fixing issue #81

Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parsing of .py looks odd is that really needd?

setup.py Outdated
# This call to setup() does all the work
setup(
name="ansible-deployer",
version="0.0.24",
version=version[2],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we import version module and just use version.version here?

Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just drop -g for rather infrequently used option and I'm good with it

source/main.py Outdated
@@ -34,16 +34,23 @@ def parse_options(argv):
' infrastructure locked after task execution.')
parser.add_argument("--debug", "-d", default=False, action="store_true",
help='Print debug output.')
parser.add_argument("--syslog", "-v", default=False, action="store_true", help='Log warnings '
parser.add_argument("--syslog", "-g", default=False, action="store_true", help='Log warnings '
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe drop -g for syslog instead? I don't see it intuitive

Increase version to 0.0.25
@LegenJCdary LegenJCdary merged commit 7df8523 into main Apr 20, 2022
@LegenJCdary LegenJCdary deleted the add_version_flag branch April 20, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants