Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic colouring #112

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Add basic colouring #112

merged 2 commits into from
Jul 4, 2022

Conversation

LegenJCdary
Copy link
Collaborator

fixing issue #92

@LegenJCdary LegenJCdary mentioned this pull request Apr 19, 2022
Closed
@LegenJCdary LegenJCdary requested a review from cinek810 April 19, 2022 08:23
cinek810
cinek810 requested changes Apr 19, 2022
View reviewed changes
Copy link
Owner

@cinek810 cinek810 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need option/environment variablee to disable if one needs.
Make it an option like -no-color and then we can add an environment variable as a deault set of options for users (separate enhancmenet)

@LegenJCdary LegenJCdary force-pushed the add_colours branch 2 times, most recently from f8b54f7 to e0627e4 Compare April 19, 2022 12:57
@LegenJCdary LegenJCdary requested a review from cinek810 April 19, 2022 13:00
@LegenJCdary LegenJCdary added the enhancement New feature or request label Apr 26, 2022
@LegenJCdary LegenJCdary force-pushed the add_colours branch 2 times, most recently from 63ce42a to 6c1b508 Compare May 20, 2022 09:21
@LegenJCdary LegenJCdary marked this pull request as draft May 20, 2022 09:25
@LegenJCdary LegenJCdary marked this pull request as ready for review May 20, 2022 09:25
@LegenJCdary LegenJCdary force-pushed the add_colours branch 2 times, most recently from 8202ed0 to 4e3367a Compare June 28, 2022 10:25
@LegenJCdary
Add CustomFormatter class colouring logging output
fbba216 
Change pre-logger criticals to format strings and add colouring
Add --no-color option to disable above
Reduce number of statements in main.parse_options
@cinek810
Copy link
Owner

just bump the version before merge

@LegenJCdary LegenJCdary merged commit 7c42bf5 into main Jul 4, 2022
@LegenJCdary LegenJCdary deleted the add_colours branch July 4, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinek810 cinek810 cinek810 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LegenJCdary @cinek810