Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-preserve option to cleanup workdir #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add --no-preserve option to cleanup workdir #136

wants to merge 2 commits into from

Conversation

LegenJCdary
Copy link
Collaborator

fixing issue #135

@LegenJCdary
Add --no-preserve option to cleanup workdir
219a81e 
Add test for this case
Add new testing function (check_file_startingwith_not_in_dir) in testing lib
@LegenJCdary LegenJCdary mentioned this pull request May 20, 2022
Open
@LegenJCdary LegenJCdary added the enhancement New feature or request label May 20, 2022
@LegenJCdary LegenJCdary requested a review from cinek810 May 20, 2022 12:21
cinek810
cinek810 reviewed Jun 2, 2022
View reviewed changes
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, today workdir is the only way to know that something was executed. This will chnage in the future when we have a recording database, but today this will result in changes not being visible to other team members, which is not what we wanted.

cinek810
cinek810 reviewed Jan 30, 2023
View reviewed changes
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we get to this option? Today I thought that something opposite - making a copy of directory even if --self-setup was used and storing the log for it may be quite nice..

@LegenJCdary
Copy link
Collaborator Author

LegenJCdary commented Jan 30, 2023 •
edited
Loading

How did we get to this option? Today I thought that something opposite - making a copy of directory even if --self-setup was used and storing the log for it may be quite nice..

100% my idea. Reasoning was that after successful execution - since no debugging is required - user might want to purge unnecessary data from storage, especially with (soon-to-be) functioning database and --syslog option. I still stand behind it but counter argument is also valid from admin pov.
Regarding --self-setup - up to the users again (who can use --debug and tee output if it's too long for their console).

@LegenJCdary LegenJCdary added this to the v3.0.0 milestone Dec 14, 2023
@cinek810 cinek810 force-pushed the main branch 5 times, most recently from 4cdc87c to c1f7847 Compare May 9, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinek810 cinek810 cinek810 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LegenJCdary @cinek810