Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback plugins #175

Merged
merged 8 commits into from
Feb 22, 2023
Merged

Callback plugins #175

merged 8 commits into from
Feb 22, 2023

Conversation

LegenJCdary
Copy link
Collaborator

No description provided.

@LegenJCdary LegenJCdary force-pushed the callback_plugins branch 5 times, most recently from 7e70c25 to 3e8934e Compare February 21, 2023 14:18
@LegenJCdary LegenJCdary requested a review from cinek810 February 21, 2023 14:48
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge that, the only major improvement for me is to have a unique id in tasks table and use INSERT "OR ABORT" instead of "INSERT OR REPLACE" there, but if it's easier to merge that and change it in separate MR I'm OK with that.

source/plugins/sqlite_deployer.py Outdated Show resolved Hide resolved
source/plugins/sqlite_deployer.py Outdated Show resolved Hide resolved
source/plugins/sqlite_deployer.py Show resolved Hide resolved
source/plugins/sqlite_deployer.py Show resolved Hide resolved
source/modules/database/writer.py Show resolved Hide resolved
@LegenJCdary LegenJCdary merged commit 1a659d9 into cinek810:main Feb 22, 2023
@LegenJCdary LegenJCdary deleted the callback_plugins branch February 22, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants