Add raw logging #191
Open
Add raw logging #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinek810
force-pushed
the
raw_log
branch
7 times, most recently
from
c1a055e to
cb6250e
Compare
LegenJCdary
requested changes
Oct 20, 2023
tests/pylintrc
Outdated
| @@ -454,7 +454,7 @@ indent-after-paren=4 | |||
| indent-string=' ' | |||
|
|
|||
| # Maximum number of characters on a single line. | |||
| max-line-length=100 | |||
| max-line-length=120 | |||
There was a problem hiding this comment.
Why? This change can be easily edited to conform to 100 chars.
source/modules/runners/run.py
Outdated
| sequence_records = db_writer.start_sequence_dict(host_list, | ||
| self.setup_hooks, options, | ||
| self.start_ts_raw, | ||
| with open(f"{self.log_path}.raw", "a", encoding="utf-8") as raw_log: |
There was a problem hiding this comment.
I would prefer to have a single point for logging and message redistribution. Is it really required at this moment? I mean, we can merge it but I will change this once I (finally? hopefully next week?) get back to ansible-deployer development.
There was a problem hiding this comment.
for me it was very helpful last days, the whole part of code is probably something we have to fully restructure to run as ansible callback plugin, so it will be a bigger change
cinek810
force-pushed
the
raw_log
branch
4 times, most recently
from
38b8146 to
f2ae113
Compare
cinek810
force-pushed
the
main
branch
5 times, most recently
from
4cdc87c to
c1f7847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.