Add show subcommand #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegenJCdary
force-pushed
the
add_show_subcommand
branch
from
8eb5836 to
3736824
Compare
cinek810
requested changes
Apr 8, 2022
|
|
||
| def verify_subcommand(command: str): | ||
| """Function to check the first arguments for a valid subcommand""" | ||
| if command not in SUBCOMMANDS: | ||
| print("[CRITICAL]: Unknown subcommand :%s", (command), file=sys.stderr) | ||
| sys.exit("55") | ||
|
|
||
| def verify_switches(switches: list): |
There was a problem hiding this comment.
Isn't that the job for validate_options?
There was a problem hiding this comment.
Show command seems unique so far because it's only subcommand that accepts following positional arguments. It doesn't make much difference from user perspective (miliseconds maybe) but I think positional and optional arguments should be validated separately. I propose merging verify_subcommand and verify_switches in this commit or after restructure (#84 ).
| @@ -589,6 +609,38 @@ def list_tasks(config: dict, options: dict): | |||
|
|
|||
| print(" ".join(task_list)) | |||
|
|
|||
| def show_deployer(config: dict, options: dict): | |||
There was a problem hiding this comment.
maybe it's a moment to move subcommand specific functions to separete file? I'm not 100% sure but if you know how to do that then go.
LegenJCdary
force-pushed
the
add_show_subcommand
branch
2 times, most recently
from
8a1ce54 to
5af864b
Compare
cinek810
approved these changes
Apr 13, 2022
LegenJCdary
force-pushed
the
add_show_subcommand
branch
2 times, most recently
from
3ec070f to
eec3675
Compare
Add function show_deployer and format_show_deployer Add tests for show subcommand in 01 and 02
LegenJCdary
force-pushed
the
add_show_subcommand
branch
from
eec3675 to
f92ccc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing issue #82