-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MSC4193: Spoilers on Media #2212
base: dev
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
If the most recent message in a room's history is a spoilered image which has been revealed, it will be re-hidden when the next message is sent. I'm not sure why this happens, but it seems to be a symptom of a bug which is out of the scope of this PR to fix. |
I have read the CLA Document and I hereby sign the CLA |
Preview: https://2212--pr-cinny.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the request changes, We should not delete list.ts
as it is a generic atom file which can be used somewhere else, or even better maybe we can change in "PUT" action to update the existing entry if it already exist.
Description
Adds support for MSC4193 by allowing users to mark image attachments as spoilers, which will blur them in the UI until explicitly revealed. The
m.spoiler.reason
field is supported for received images, although this PR does not add a way to set it for sent images.Fixes #1966
Type of change
Checklist: