Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init fiattokenfactory migration #2

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

kaliweh-circle
Copy link
Contributor

Changes:

@johnletey johnletey mentioned this pull request Oct 20, 2023
Copy link

@walkerq walkerq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review process:

  1. Cloned this repo, and https://github.com/strangelove-ventures at commit 80b6364323157317678d8020bc42418628f333d2
  2. Compared this repo (on migration branch), to the strangelove-ventures repo, for the fiattokenfactory files included in this PR:
git diff ./testutil ../../noble-old/noble/testutil > testutils_diff.txt
git diff ./x/fiattokenfactory ../../noble-old/noble/x/fiattokenfactory > x_fiattokenfactory_diff.txt
git diff ./proto/fiattokenfactory ../../noble-old/noble/proto/fiattokenfactory > proto_fiattokenfactory_diff.txt
  1. Validated that there are no changes

@kaliweh-circle kaliweh-circle merged commit 2dae0cf into circlefin:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants