Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document required PR lables #351

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Document required PR lables #351

merged 2 commits into from
Jul 4, 2019

Conversation

fkorotkov
Copy link
Contributor

Fixes #343

@fkorotkov fkorotkov mentioned this pull request Jul 4, 2019
Closed
dnfield
dnfield reviewed Jul 4, 2019
View reviewed changes
docs/guide/writing-tasks.md
# ...

test_task:
required_pr_labels: initial-review
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have multiple labels, either inclusive or exclusive?

e.g. only run this task if all labels, or only run this task if at least one of the following labels?

Not sure if that's really needed, more curious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can specify multiple labels and they all should be presented on the PR. For example:

build_task:
  required_pr_labels:
    - cla-signed
    - initial-review

task:
  name: Deploy Staging
  depends_on: build
  required_pr_labels:
    - cla-signed
    - initial-review
    - ready-for-staging

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok - that would be helpful as an example in the doc

@dnfield
Copy link

dnfield commented Jul 4, 2019

This is awesome! thanks!

@fkorotkov fkorotkov merged commit 4461280 into master Jul 4, 2019
@fkorotkov fkorotkov deleted the fedor/required-pr-labels branch July 4, 2019 12:33
fkorotkov added a commit that referenced this pull request Mar 27, 2024
@fkorotkov
Document fetching Git tags
495df30 
Fixes #351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger tasks based on label(s)
2 participants
@fkorotkov @dnfield