-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git based deployment versioning and other deploy.sh improvements #112
Merged
mreeve-snl
merged 2 commits into
release-1.3.0
from
mreeve-69-git_based_deployment_versioning
Dec 19, 2023
Merged
git based deployment versioning and other deploy.sh improvements #112
mreeve-snl
merged 2 commits into
release-1.3.0
from
mreeve-69-git_based_deployment_versioning
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll comment here when this is ready |
mreeve-snl
requested review from
adhilto,
mitchelbaker-cisa,
cbaxley and
llwaterhouse
and removed request for
mitchelbaker-cisa
December 15, 2023 21:36
mreeve-snl
changed the title
Mreeve 69 git based deployment versioning
git based deployment versioning
Dec 16, 2023
When we're testing this, we'll want to use the following command:
that way the version set in lme.conf will be appropriate and expected. |
mreeve-snl
changed the title
git based deployment versioning
git based deployment versioning and updating
Dec 16, 2023
mreeve-snl
changed the title
git based deployment versioning and updating
git based deployment versioning and updating dashboards
Dec 16, 2023
mreeve-snl
changed the title
git based deployment versioning and updating dashboards
git based deployment versioning and other deploy.sh improvements
Dec 16, 2023
cbaxley
previously approved these changes
Dec 18, 2023
OK release is ready for testing/approval! |
llwaterhouse
approved these changes
Dec 18, 2023
mitchelbaker-cisa
force-pushed
the
mreeve-69-git_based_deployment_versioning
branch
from
December 18, 2023 23:45
9beac38
to
28cfe81
Compare
mitchelbaker-cisa
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgraded to latest version and ran clean install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Adds git control into LME's version process
fixes "bug" in deploy.sh:
Chapter\ 3\ Files
directory are preseserved!upgrade function with 1.2.0 -> 1.3.0, upgrade path
adds various features to deploy.sh:
💭 Motivation and context
LME versioning should be tracked automatically via git and the installed version should be automatically tracked via git.
There was a little QOL of changes need for deploy.sh as well.
Solves: #69
🧪 Testing
Tested on a clean install of 1.2.0 -> upgrade 1.3.0
tested on a clean install of 1.3.0 on this branch
✅ Pre-approval checklist
to reflect the changes in this PR.