Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove screenshot column #26

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Remove screenshot column #26

merged 2 commits into from
Nov 10, 2023

Conversation

adhilto
Copy link
Contributor

@adhilto adhilto commented Nov 9, 2023

🗣 Description

Removed the screenshot column from the setup testbed instructions.

💭 Motivation and context

The images were all resulting in 404 errors and the instructions are clear enough without them.

🧪 Testing

N/A

📷 Screenshots (if appropriate)

image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@adhilto adhilto added the documentation This issue or pull request improves or adds to documentation label Nov 9, 2023
@adhilto adhilto self-assigned this Nov 9, 2023
Copy link
Contributor

@rgbrow1949 rgbrow1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Piece of cake, Approved.

@mreeve-snl
Copy link
Collaborator

https://github.com/cisagov/LME/tree/patch-testbed-instructions/testing
fixed it :)
I'll approve, and let one of you merge it

Copy link
Collaborator

@mreeve-snl mreeve-snl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adhilto adhilto merged commit 23e6e7c into main Nov 10, 2023
3 checks passed
@adhilto adhilto deleted the patch-testbed-instructions branch November 10, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants