Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix awarz 531 remove inline comments #536

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

aarz-snl
Copy link
Collaborator

@aarz-snl aarz-snl commented Dec 16, 2024

🗣 Description

Removing inline comments

💭 Motivation and context

Inline comments cause parsing issues and need to be removed ASAP.

📷 Screenshots (DELETE IF UNAPPLICABLE)

🧪 Testing

Tested in previous merges to develop

✅ Pre-approval checklist

  • Changes are limited to a single goal AND
    the title reflects this in a clear human readable format
  • Issue that this PR solves has been selected in the Development section
  • I have read and agree to LME's CONTRIBUTING.md document.
  • The PR adheres to LME's requirements in RELEASES.md
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • All tests pass
  • PR has been tested and the documentation for testing is above
  • Squash and merge all commits into one PR level commit

✅ Post-merge Checklist

  • Delete the branch to keep down number of branches

@aarz-snl aarz-snl requested a review from mreeve-snl December 16, 2024 17:02
@aarz-snl
Copy link
Collaborator Author

Had to rename to match naming convention

@mreeve-snl
Copy link
Collaborator

tested locally, mitigates issues with kibana borking an installation process
please merge :)

@aarz-snl aarz-snl merged commit 302e824 into main Dec 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants