Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it so that the scubagoggles reports link to the baselines #200

Closed
1 task
adhilto opened this issue Feb 16, 2024 · 0 comments · Fixed by #323
Closed
1 task

Make it so that the scubagoggles reports link to the baselines #200

adhilto opened this issue Feb 16, 2024 · 0 comments · Fixed by #323
Assignees
@jfevang
Labels
enhancement
Milestone
Coast

Comments

@adhilto
Copy link
Collaborator

adhilto commented Feb 16, 2024

💡 Summary

Make it so that the control group names in the report are links to their respective groups in the baseline.
image

Motivation and context

Nice to have feature, making it easier for users to learn more about the controls.

Implementation notes

Feature already present in ScubaGear. Might be worthwhile looking at the implementation there for lessons learned.

Acceptance criteria

  • The group titles are links
@adhilto adhilto changed the title Make it so that the scubagoggles report link to the baselines Make it so that the scubagoggles reports link to the baselines Feb 16, 2024
@adhilto adhilto added this to the TBD 0.3 Milestone milestone Feb 20, 2024
@adhilto adhilto mentioned this issue Jun 10, 2024
Closed
1 task
jfevang added a commit that referenced this issue Jun 21, 2024
@jfevang
#200 added reports link to baselines
fb1a871
jfevang added a commit that referenced this issue Jun 21, 2024
@jfevang
#200 fixing pylint error with f-string
5d479de
jfevang added a commit that referenced this issue Jun 21, 2024
@jfevang
#200 fixing pylint errors
0979ddb
jfevang added a commit that referenced this issue Jun 21, 2024
@jfevang
#200 fixing pylint errors
e398fc8
jfevang added a commit that referenced this issue Jun 21, 2024
@jfevang
#200 fixing pylint errors
7e655bb
@jfevang jfevang mentioned this issue Jun 21, 2024
Merged
14 tasks
@jfevang jfevang linked a pull request Jun 21, 2024 that will close this issue
Make it so that the scubagoggles reports link to the baselines #323
Merged
14 tasks
buidav pushed a commit that referenced this issue Jul 3, 2024
@jfevang @adhilto
Make it so that the scubagoggles reports link to the baselines (#323)
9401ead 
* #200 added reports link to baselines

* #200 fixing pylint error with f-string

* #200 fixing pylint errors

* #200 fixing pylint errors

* #200 fixing pylint errors

* Update scubagoggles/reporter/reporter.py

Co-authored-by: Alden Hilton <[email protected]>

* #312 updated group_reference_url variable to add to ScubaResults.json file, similar to ScubaGear

* #312 fixing pylint error

* #312 fixed spacing encoding in URL

* #312 added variables for baseline version and tool version

---------

Co-authored-by: Alden Hilton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfevang jfevang

Labels
enhancement
Projects
None yet
Milestone
Coast
Development

Successfully merging a pull request may close this issue.

Make it so that the scubagoggles reports link to the baselines cisagov/ScubaGoggles
2 participants
@adhilto @jfevang