Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#new-87-detailed-report-message-for-groups #301

Merged
merged 9 commits into from
Aug 7, 2024

Conversation

snarve
Copy link
Collaborator

@snarve snarve commented Jun 4, 2024

🗣 Description

Detailed report messages for Groups

Closes #87

💭 Motivation and context

This issue is part of epic #90

🧪 Testing

All reports and unit tests should pass all use cases

Note: Policy 7 is not updated with detailed report message. If it is applicable this can be handled as a separate issue post Barracuda release.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@snarve snarve added this to the Barracuda milestone Jun 4, 2024
@snarve snarve requested review from buidav and adhilto June 4, 2024 01:13
@snarve snarve self-assigned this Jun 4, 2024
@snarve
Copy link
Collaborator Author

snarve commented Jun 4, 2024

@buidav this issue has other old branches, didn't delete those yet to avoid any conflicts /merge issues. This is current updated branch with all the updates. The other branches are good to delete.

@buidav buidav modified the milestones: Barracuda, Coast Jun 5, 2024
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. I do have some feedback, but all minor stuff.

rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Show resolved Hide resolved
@buidav buidav merged commit 5cc10af into main Aug 7, 2024
3 checks passed
@buidav buidav deleted the new-87-detailed-report-message-for-groups branch August 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detailed Report message - Groups
3 participants