Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meet: implement group checks (issue 320) #329

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Jul 10, 2024

🗣 Description

Implemented checking of groups for GWS.MEET.1.1v0.2, GWS.MEET.2.1v0.2, GWS.MEET.3.1v0.2, and GWS.MEET.4.1v0.2.

💭 Motivation and context

Added checking for non-compliant groups in meet.rego for the 4 requirements.

Closes #320

🧪 Testing

Manually tested MEET 1-4 using scubagws.org admin settings on groups.

Added Rego tests for all 4 requirements.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added this to the Coast milestone Jul 10, 2024
@adhilto adhilto added the bug This issue or pull request addresses broken functionality label Jul 10, 2024
@adhilto adhilto assigned adhilto and rlxdev and unassigned adhilto Jul 10, 2024
@adhilto adhilto self-requested a review July 10, 2024 20:02
@adhilto adhilto requested a review from LaurenBassett July 23, 2024 17:37
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@adhilto adhilto merged commit f32cf59 into main Jul 25, 2024
6 checks passed
@adhilto adhilto deleted the 320-meet-group-support branch July 25, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meet settings not being checked at the group level
3 participants