Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#328] Default Safe variable is incorrect in many cases #343

Merged
merged 16 commits into from
Aug 21, 2024
Merged

Conversation

snarve
Copy link
Collaborator

@snarve snarve commented Aug 8, 2024

🗣 Description

Default Safe variable is incorrect in many cases

Closes #328

💭 Motivation and context

The Default Safe variable was assigned an incorrect value in many of the baselines and this was resulting in incorrect conditional checks when there are no log events present for a given policy.

🧪 Testing

  • Testing may involve testing in a default setting environment (potentially new environment) where the settings/controls are unchanged and there are no log events.

  • Another work around to test this is to delete the logs from the 'ProviderSettingExport.json' file, that way no log events will be present and the DefaultSafe value can be tested

  • This update touched many of the baseline policies and corresponding unit tests, so ensure everything is working as expected

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@snarve snarve added this to the Coast milestone Aug 8, 2024
@snarve snarve requested a review from LaurenBassett August 8, 2024 16:00
@snarve snarve self-assigned this Aug 8, 2024
@snarve snarve requested a review from adhilto August 12, 2024 17:11
@snarve
Copy link
Collaborator Author

snarve commented Aug 13, 2024

@adhilto @mitchelbaker-cisa @LaurenBassett this PR is ready for review.

rego/Groups.rego Outdated Show resolved Hide resolved
rego/Groups.rego Outdated Show resolved Hide resolved
rego/Meet.rego Outdated Show resolved Hide resolved
@snarve snarve requested a review from buidav August 20, 2024 17:41
@adhilto adhilto merged commit 2e00bf2 into main Aug 21, 2024
3 checks passed
@adhilto adhilto deleted the defaultSafe_328 branch August 21, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultSafe variable is incorrect in many cases
4 participants