generated from cisagov/ScubaGear
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#328] Default Safe variable is incorrect in many cases #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@adhilto @mitchelbaker-cisa @LaurenBassett this PR is ready for review. |
adhilto
reviewed
Aug 13, 2024
snarve
commented
Aug 13, 2024
adhilto
approved these changes
Aug 15, 2024
mitchelbaker-cisa
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Default Safe variable is incorrect in many cases
Closes #328
💭 Motivation and context
The Default Safe variable was assigned an incorrect value in many of the baselines and this was resulting in incorrect conditional checks when there are no log events present for a given policy.
🧪 Testing
Testing may involve testing in a default setting environment (potentially new environment) where the settings/controls are unchanged and there are no log events.
Another work around to test this is to delete the logs from the 'ProviderSettingExport.json' file, that way no log events will be present and the DefaultSafe value can be tested
This update touched many of the baseline policies and corresponding unit tests, so ensure everything is working as expected
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist