Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the baseline markdown files #354

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Aug 21, 2024

🗣 Description

Shorten the file names of the baseline markdown files (e.g., change "Common Controls Minimum Viable Secure Configuration Baseline v0.2.md" to "commoncontrols.md")

💭 Motivation and context

Closes #314.

🧪 Testing

Ran ScubaGoggles, verified that:

  • It successfully runs to completion
  • The links to the group names included in the are correct (they won't work as is because they're pinned to the v0.2.0 release, but if you edit the url and replace that with "314-rename-the-baseline-markdown-files" they work)
  • The links in the Readme files still work

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added this to the Coast milestone Aug 21, 2024
@adhilto adhilto requested review from rlxdev and snarve August 21, 2024 00:25
@adhilto adhilto self-assigned this Aug 21, 2024
@adhilto adhilto linked an issue Aug 21, 2024 that may be closed by this pull request
2 tasks
@buidav buidav self-requested a review August 23, 2024 23:18
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we didn't hard write the absolute URL anywhere else.

Copy link
Collaborator

@snarve snarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, reports are working as expected.

@snarve snarve merged commit 60f51f3 into main Aug 26, 2024
14 checks passed
@snarve snarve deleted the 314-rename-the-baseline-markdown-files branch August 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the baseline markdown files
3 participants