Correct the "No Such Event" behavior for Gmail policies with multiple settings #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
GWS.GMAIL.5.5v0.3 and GWS.GMAIL.7.6v0.3 both had custom "no such event" rules, as they both rely on multiple settings. Before, the logic of these rules was basically, "if any of these settings have at least one event, set no such event to false." I changed the logic to "If any of these settings have no events, set no such event to true."
💭 Motivation and context
Closes #368. TLDR: the old logic was resulting in false negatives.
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist