Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated instructions for Classroom1.2 #401

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Updated instructions for Classroom1.2 #401

merged 2 commits into from
Sep 13, 2024

Conversation

k-winters
Copy link
Collaborator

🗣 Description

Updated classroom instructions for Classroom1.2

💭 Motivation and context

Closes #380

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@k-winters k-winters self-assigned this Sep 12, 2024
@k-winters k-winters linked an issue Sep 12, 2024 that may be closed by this pull request
Classroom 1.2 Implementation #380
Closed
adhilto
adhilto reviewed Sep 12, 2024
View reviewed changes
baselines/classroom.md Outdated Show resolved Hide resolved
@adhilto adhilto merged commit df7cf25 into main Sep 13, 2024
4 checks passed
@adhilto adhilto deleted the 380-classroom-12-implementation branch September 13, 2024 16:22
@adhilto adhilto restored the 380-classroom-12-implementation branch September 13, 2024 16:24
adhilto added a commit that referenced this pull request Sep 13, 2024
@adhilto
Revert "Updated instructions for Classroom1.2 (#401)"
f734e7a 
This reverts commit df7cf25.
@adhilto adhilto mentioned this pull request Sep 13, 2024
Merged
14 tasks
adhilto added a commit that referenced this pull request Sep 13, 2024
@adhilto
Revert "Updated instructions for Classroom1.2 (#401)" (#405)
d6b34c4 
This reverts commit df7cf25.
@buidav buidav deleted the 380-classroom-12-implementation branch September 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdueltgen mdueltgen mdueltgen approved these changes

@adhilto adhilto adhilto approved these changes

@buidav buidav Awaiting requested review from buidav

Assignees

@k-winters k-winters

Labels
Baseline Revision Google Classroom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Classroom 1.2 Implementation
3 participants
@k-winters @adhilto @mdueltgen