generated from cisagov/ScubaGear
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config file support for existing parameters #413
Merged
adhilto
merged 20 commits into
main
from
403-add-config-file-support-for-existing-parameters
Sep 23, 2024
Merged
Add config file support for existing parameters #413
adhilto
merged 20 commits into
main
from
403-add-config-file-support-for-existing-parameters
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github.com:cisagov/ScubaGoggles into 403-add-config-file-support-for-existing-parameters
… github.com:cisagov/ScubaGoggles into 403-add-config-file-support-for-existing-parameters
2 tasks
mitchelbaker-cisa
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Tested with/without a config file when run via scubagoggles gws and scuba.py. Tested with parameters in both config file/command-line, and with a mix of full param names/aliases.
Left one comment for consideration.
LaurenBassett
approved these changes
Sep 23, 2024
Tests ran fine for me :-) |
adhilto
deleted the
403-add-config-file-support-for-existing-parameters
branch
September 23, 2024 20:49
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Added config file support for the existing ScubaGoggles parameters. See https://github.com/cisagov/ScubaGoggles/blob/403-add-config-file-support-for-existing-parameters/docs/usage/Config.md for usage details.
💭 Motivation and context
Closes #403.
🧪 Testing
Note this adds a new dependency: pyyaml. Be sure to install that before testing.
Manually tested:
-b
vs--baselines
)✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist