Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct no log event found for Gmail.14.1v03 #468

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Correct no log event found for Gmail.14.1v03 #468

merged 4 commits into from
Oct 11, 2024

Conversation

LaurenBassett
Copy link
Contributor

@LaurenBassett LaurenBassett commented Oct 8, 2024 •
edited by buidav
Loading

🗣 Description

Fixes the issue found during functional testing where Gmail.14.1v03 was not working appropriately.

💭 Motivation and context

Closes #463

Why is this change required?

It appears that the setting for adding IP addresses to the email allowlist changed. Instead of EMAIL_SPAM_ALLOWLIST, the new code searches for GmailIpWhitelistSpamFilteringProto is_empty which returns "true" when the list is empty, and false when it is not.

The setting GmailIpWhitelistSpamFilteringProto ip_whitelist_spam_filtering does not return a New Value when the list is empty, and is categorized under DELETE_APPLICATION_SETTING and not change.

For detailed report messages in the future, we may want to add the IP list back in.

Screenshot 2024-10-08 at 1 55 36 PM

🧪 Testing

Updated the tests appropriately.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@LaurenBassett LaurenBassett linked an issue Oct 8, 2024 that may be closed by this pull request
GWS.GMAIL.14.1v0.3 - No Log Event Found #463
Closed
@LaurenBassett LaurenBassett added this to the Coast milestone Oct 9, 2024
@adhilto adhilto added the bug This issue or pull request addresses broken functionality label Oct 9, 2024
adhilto
adhilto reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just one small thing:

rego/Gmail.rego Outdated Show resolved Hide resolved
@buidav buidav changed the title 463 gwsgmail141v03 no log event found Correct no log event found for Gmail.14.1v03 Oct 10, 2024
@buidav buidav merged commit 3feea1c into main Oct 11, 2024
11 checks passed
@buidav buidav deleted the 463-gwsgmail141v03-no-log-event-found branch October 11, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto adhilto approved these changes

@buidav buidav buidav approved these changes

Assignees

@LaurenBassett LaurenBassett

Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
Coast
Development

Successfully merging this pull request may close these issues.

GWS.GMAIL.14.1v0.3 - No Log Event Found
3 participants
@LaurenBassett @buidav @adhilto