-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all f-strings to use .format #756
Conversation
Looks like the pylint is failing in the Backend Pipeline / Test (pull_request) I guess they want you to use %s with logger instead of format. Not sure why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good!
Also went through the full local build process and tested all frontend pages. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🗣 Description
Replace all Python f-strings to use the .format() method for formatting.
💭 Motivation and context
In the interest of security against injection attacks, all Python f-strings have been replaced with their equivalent with the format() method.
🧪 Testing
Tested by rebuilding the entire project, and running the entire PyTest suite.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.