Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegionAdmin Manage Users Bugfix #758

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Jan 14, 2025

…user.py)
resolves CRASM-1059. Bugfix to remove 401 error on manage users as a regionalAdmin user type.

🗣 Description

Fix users backend endpoint so regionalAdmin user type can access the manage users page.

💭 Motivation and context

🧪 Testing

As a regionalAdmin user, you should now be able to get the "Manage Users" Screen without seeing any errors.

@nickviola nickviola self-assigned this Jan 14, 2025
@nickviola nickviola marked this pull request as ready for review January 14, 2025 21:06
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_global_view_admin andis_regional_admin could be optimized to make these checks at the ORM call to organize at the data layer. If this is something we want to do in the future make a ticket and note here. Other than that this PR LGTM

Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants