Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mini datalake to crossfeed #762

Merged
merged 18 commits into from
Jan 21, 2025
Merged

Add Mini datalake to crossfeed #762

merged 18 commits into from
Jan 21, 2025

Conversation

DJensen94
Copy link
Contributor

🗣 Description

This PR adds the Mini datalake models, db_router, and sync script. Allowing developers to stand up a mini datalake locally.

💭 Motivation and context

This allows us to stand up the mini datalake to the side of the XFD database, this will allow us to develop in tandem connecting to both databases to aid in transitioning to fully using the Mini datalake.

🧪 Testing

We have tested locally standing up the mini datalake

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

DJensen94 and others added 9 commits January 8, 2025 11:27
Add new app and models
add models to the app
… local

Removing 2nd db container for local makes the environment more consistent with production as we use only 1 RDS instance for multiple dbs
Fix class tabbing for vuln scan meta data
adding null permission
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Clean Build and Tests

Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDL stood up for me.

@schmelz21 schmelz21 merged commit 6b24fe4 into develop Jan 21, 2025
15 checks passed
@schmelz21 schmelz21 deleted the DJ_add-mdl-WIP branch January 21, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants