Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Frontend node_modules vulnerabilities (CRASM-1076) #763

Merged
merged 17 commits into from
Jan 17, 2025

Conversation

hawkishpolicy
Copy link
Collaborator

Updating node packages to remove vulnerabilities.

πŸ—£ Description

πŸ’­ Motivation and context

πŸ§ͺ Testing

  • Tested locally.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

- addresses Server-Side Request Forgery
- Affects vulnerable versions of body-parser, cookie, path-to-regexp, send, and serve-static.
@hawkishpolicy hawkishpolicy added the dependencies Pull requests that update a dependency file label Jan 16, 2025
@hawkishpolicy hawkishpolicy self-assigned this Jan 16, 2025
- Addresses Regex Denial of Service (ReDoS) in cross-spawn.
- Resolves case of malicious HTML using special nesting techniques to bypass depth checking.
- Resolves use of Prototype Pollution to weaken depth checking.
- Resolves vulnerability to nesting based mXSS.
- Installed caniuse 1.0.30001692
- the latest version contains the aforementioned vulnerabilities.
- Resolves ReDOS vulnerability at currency parsing.
- Addresses DoS in hhtp-proxy-middleware.
- Addresses predictable results in nanoid generation when given non-integer values.
- Addresses the output of backtracking regular expressions.
- DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS.
- Webpack's AutoPublicPathRuntimeModule has a DOM Clobbering Gadget that leads to XSS.
- Addresses low level vulnerabilities relating to the following dependencies:
  - @aws-amplify/analytics
  - @aws-amplify/api
  - @aws-amplify/auth
  - @aws-amplify/cache
  - @aws-amplify/core
  - @aws-amplify/datastore
  - @aws-amplify/geo
  - @aws-amplify/interactions
  - @aws-amplify/notifications
  - @aws-amplify/predictions
  - @aws-amplify/pubsub
  - @aws-amplify/storage
- Addresses instances where cookie accepts name, path, and domain with out of bounds characters.
- This could be a breaking change.
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 2c136b2 into develop Jan 17, 2025
13 of 14 checks passed
@schmelz21 schmelz21 deleted the Frontend-Node-Modules-CRASM-1076 branch January 17, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants