-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Frontend node_modules vulnerabilities (CRASM-1076) #763
Merged
+1,790
β3,157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- addresses Server-Side Request Forgery
- Affects vulnerable versions of body-parser, cookie, path-to-regexp, send, and serve-static.
- Addresses Regex Denial of Service (ReDoS) in cross-spawn.
- Resolves case of malicious HTML using special nesting techniques to bypass depth checking. - Resolves use of Prototype Pollution to weaken depth checking. - Resolves vulnerability to nesting based mXSS.
- Installed caniuse 1.0.30001692
- the latest version contains the aforementioned vulnerabilities.
- Resolves ReDOS vulnerability at currency parsing.
- Addresses DoS in hhtp-proxy-middleware.
- Addresses predictable results in nanoid generation when given non-integer values.
- Addresses the output of backtracking regular expressions.
- DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS.
- Webpack's AutoPublicPathRuntimeModule has a DOM Clobbering Gadget that leads to XSS.
- Addresses low level vulnerabilities relating to the following dependencies: - @aws-amplify/analytics - @aws-amplify/api - @aws-amplify/auth - @aws-amplify/cache - @aws-amplify/core - @aws-amplify/datastore - @aws-amplify/geo - @aws-amplify/interactions - @aws-amplify/notifications - @aws-amplify/predictions - @aws-amplify/pubsub - @aws-amplify/storage
- Addresses instances where cookie accepts name, path, and domain with out of bounds characters. - This could be a breaking change.
hawkishpolicy
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
January 17, 2025 17:27
schmelz21
approved these changes
Jan 17, 2025
nickviola
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating node packages to remove vulnerabilities.
π£ Description
π Motivation and context
π§ͺ Testing
β Pre-approval checklist
β Pre-merge checklist
β Post-merge checklist