Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement standard container tests #6

Open
2 tasks
king-alexander opened this issue Feb 16, 2023 · 1 comment
Open
2 tasks

Implement standard container tests #6

king-alexander opened this issue Feb 16, 2023 · 1 comment
Assignees
@king-alexander
Labels
docker Pull requests that update Docker code test This issue or pull request adds or otherwise modifies test code

Comments

@king-alexander
Copy link
Collaborator

king-alexander commented Feb 16, 2023 •
edited
Loading

💡 Summary

Modify the standard container tests to work in this repository.

Motivation and context

The standard test harness doesn't play nice with the way Admiral is composed. The configuration expects a main container and version container from which to derive tests. But that causes complications.

Admiral's composition does not have a main container. Instead, a template is used to replicate workers. Because there is no main container, it's not possible for the tests to verify an output or clean exit. We need to find a way to test the replica containers instead.

Implementation notes

Acceptance criteria
@king-alexander king-alexander closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
@king-alexander king-alexander mentioned this issue Feb 23, 2023
Merged
12 tasks
@king-alexander king-alexander moved this from WAITING to READY in 👨‍✈️ Admiral Apr 19, 2023
@king-alexander king-alexander self-assigned this Apr 19, 2023
@king-alexander king-alexander added docker Pull requests that update Docker code test This issue or pull request adds or otherwise modifies test code labels Jun 23, 2023
@king-alexander king-alexander mentioned this issue Jun 23, 2023
Closed
@king-alexander king-alexander added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 23, 2023
@king-alexander
Copy link
Collaborator Author

Waiting to merge #5 before I begin work on this issue.

@king-alexander king-alexander moved this from READY to BACKLOG in 👨‍✈️ Admiral Jun 23, 2023
king-alexander added a commit that referenced this issue Aug 22, 2023
@king-alexander
Configure python_on_whales pytest plugin
0dbd4a3 
This commit instantiates a Docker client with the Docker Compose file path and the
project name. It also comments out the main container configuration,
which causes tests to fail per #6.
@king-alexander king-alexander removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Sep 8, 2023
@king-alexander king-alexander moved this from BACKLOG to READY in 👨‍✈️ Admiral Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@king-alexander king-alexander

Labels
docker Pull requests that update Docker code test This issue or pull request adds or otherwise modifies test code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@king-alexander