Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build user support a single build environment #62

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Jan 14, 2025

🗣 Description

This PR modifies the build user that is created by this module such that the user can only build AMIs in a single environment.

💭 Motivation and context

In the past, we had a single build user that was capable of building AMIs in both a staging and production environment. In our target (near-future) state, each packer repo will have one build user per environment (e.g. dev, staging, production, etc.)

This supports our overall goal of a COOL system where each environment's IAM users exist in an AWS account specific to that environment and no others.

Note

I am marking this PR as "blocked" until the related skeleton-packer PR (cisagov/skeleton-packer#393) has been reviewed and approved, to minimize the amount of time that our cisagov packer repos are out of sync with the latest changes in this module.

🧪 Testing

I used the version of the module in this PR to successfully create dev, staging, and production build users for cisagov/skeleton-packer#393.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Post-merge checklist

dav3r added 7 commits January 14, 2025 10:58
We no longer want providers for Production and Staging because our planned future state prevents Production and Staging accounts from co-mingling in the same AWS organization.
… AMI-creation role in this module

cisagov/ci-iam-user-tf-module is no longer useful in our target state with separate Production and Staging environments.
Also, make some more changes related to the removal of cisagov/ci-iam-user-tf-module.
@dav3r dav3r added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Jan 14, 2025
@dav3r dav3r self-assigned this Jan 14, 2025
@dav3r dav3r requested a review from a team January 14, 2025 22:07
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with one question.

README.md Show resolved Hide resolved
For unknown reasons, terraform-docs is not including this provider.  Re-running terraform-docs will remove it, but that change should be ignored.

Co-authored-by: Jeremy Frasier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants